Make sure FUIAuthDelegate methods get called for Firebase 11 #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
approved these changes
Aug 19, 2024
paulb777
added a commit
that referenced
this pull request
Aug 22, 2024
Update sample based on learnings discussed in #1203
paulb777
added a commit
that referenced
this pull request
Aug 22, 2024
Update sample based on learnings discussed in #1203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1198
The function
func authUI(_ authUI: FUIAuth, didSignInWith authDataResult: AuthDataResult?, error: Error?)maps to Objective C selectors differently between Firebase 10 and Firebase 11.With Firebase 10, it becomes
With Firebase 11, it becomes
Also, with Firebase 11, an
@objcis required on Swift implementations.