Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/include reuirement lockfile #41

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

fioreale
Copy link
Owner

@fioreale fioreale commented Oct 3, 2024

Description

This PR includes several updates to improve documentation, update the Docker image, and manage dependencies more effectively.

Changes

1. Update README (1f48aa2)

  • Updated the frontend port in the README from 4173 to 5173.
  • This change ensures that the documentation accurately reflects the correct port for accessing the frontend application.

2. Update Docker image Python version (75f2199)

  • Changed the base Docker image from python:3.12-slim to python:3.12.5-slim.
  • This update specifies a more precise Python version, which can help with reproducibility and consistency across different environments.

3. Include requirements lockfile (7738ed9)

  • Added requirements.lock file to the project.
  • Updated .gitignore to exclude *-dev.lock files instead of all *.lock files.
  • Added an entry to the frontend's .gitignore file.
  • Removed package-lock.json from the frontend project.

Rationale

  • The README update ensures that users can correctly access the frontend application.
  • Specifying a precise Python version in the Dockerfile helps maintain consistency across different environments and makes the build process more reproducible.
  • Including a requirements.lock file helps lock down dependency versions, ensuring consistent builds across different environments.

@fioreale fioreale merged commit f3cc78b into master Oct 3, 2024
@fioreale fioreale deleted the chore/include-reuirement-lockfile branch October 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant