Enable icons gallery in storybook and update deps #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable `*.stories.mdx` in Storybook config. Comment out Subtitle from Icons story to avoid error: "Error: No primary story defined for docs entry. Did you forget to use `<Meta>`?" This error seems to be related to: storybookjs/storybook#19964 storybookjs/storybook#22490
Add ts-lit-plugin dependency explicitly since it is used in tsconfig.json but was not a direct dependency. Bump dev dependencies (only backwards compatible versions).
Add missing import for fds-icon. Add missing property type for boolean property.
ninopenttinen
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ts-lit-plugindependency explicitly since it is used intsconfig.jsonbut was not a direct dependency.Bump dev dependencies (only backwards compatible versions).
Fix lint issues in
fds-button.tsAdd missing import for fds-icon.
Add missing property type for boolean property.
Enable
*.stories.mdxin Storybook config so that the existing Icons page will be shown in storybook.Comment out Subtitle from Icons story to avoid error: "Error: No primary story defined for docs entry. Did you forget to use
<Meta>?"This error seemed to be related to:
storybookjs/storybook#19964
storybookjs/storybook#22490