Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Groups: Trying to subscribe to a favourites group throws error but nothing displayed on UI #6552

Closed
jessica-woodland-scott-db opened this issue Apr 12, 2023 · 1 comment
Closed

App Groups: Trying to subscribe to a favourites group throws error but nothing displayed on UI #6552

jessica-woodland-scott-db opened this issue Apr 12, 2023 · 1 comment
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life small change Should be a simple, low complexity issue
Milestone
1.49

Comments

@jessica-woodland-scott-db
Copy link
Contributor

Description

Cannot subscribe to someone elses favourites, but nothing to inform user this request was rejected

Waltz Version

No response

Steps to Reproduce

...

Expected Result

No response

Actual Result

No response
@jessica-woodland-scott-db jessica-woodland-scott-db added bug Defect affecting the currently released version of Waltz small change Should be a simple, low complexity issue QoL Quality of Life labels Apr 12, 2023
@jessica-woodland-scott-db jessica-woodland-scott-db added this to the next : 1.49 milestone Apr 12, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Apr 18, 2023
@davidwatkins73
Prevent users from subscribing to other peoples favourite groups
aeaec5e 
finos#6552
@davidwatkins73 davidwatkins73 mentioned this issue Apr 18, 2023
Merged
@davidwatkins73 davidwatkins73 changed the title App Groups: Trying to subscribe to a favoueites group throws error but nothing displayed on UI App Groups: Trying to subscribe to a favourites group throws error but nothing displayed on UI Apr 18, 2023
@davidwatkins73
Copy link
Member

Decided to hide the subscribe button when viewing favourite groups (as it will never work).

@jessica-woodland-scott-db jessica-woodland-scott-db added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Apr 20, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.49, 1.49 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life small change Should be a simple, low complexity issue
Projects
None yet
Milestone
1.49
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db