Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment Definitions: prevent MVA -> SVA switch if ratings exist #6529

Closed
davidwatkins73 opened this issue Mar 29, 2023 · 0 comments
Closed

Assessment Definitions: prevent MVA -> SVA switch if ratings exist #6529

davidwatkins73 opened this issue Mar 29, 2023 · 0 comments
Assignees
@jessica-woodland-scott-db
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Milestone
1.48.1

Comments

@davidwatkins73
Copy link
Member

Description

We shouldn't allow multi valued assessments to go back to being single-valued if mappings already exist.
Bonus points if we limit the check to see if multi valued ratings already exist (i.e. permit if it all looks like SVA's already)

Resourcing

We would like to add this request to the Waltz team's feature backlog
@davidwatkins73 davidwatkins73 added the QoL Quality of Life label Mar 29, 2023
@davidwatkins73 davidwatkins73 added this to the todo : 1.48.1 milestone Mar 29, 2023
@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Apr 5, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Apr 12, 2023
@jessica-woodland-scott-db
Add column description to derived cols -WIP!
f5477ae 
#CTCTOWALTZ-2663
finos#6529
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Apr 12, 2023
@jessica-woodland-scott-db
Prevent switch from MVA -> SVA if there are any MVA assessment ratings
e7c9721 
#CTCTOWALTZ-2663
finos#6529
Merged
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Apr 12, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.49, 1.48.1 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessica-woodland-scott-db jessica-woodland-scott-db

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Projects
None yet
Milestone
1.48.1
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db