Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Costs: allow user to switch year #6508

Closed
davidwatkins73 opened this issue Mar 20, 2023 · 1 comment
Closed

Costs: allow user to switch year #6508

davidwatkins73 opened this issue Mar 20, 2023 · 1 comment
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone
1.48

Comments

@davidwatkins73
Copy link
Member

Description

User (NH) would like to be able to select which year to show costs for (currently just defaults to the latest available).

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Mar 20, 2023
@davidwatkins73 davidwatkins73 self-assigned this Mar 25, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
dce657d 
- done the basic dao and services

TODO
- need to worry about the costService
- AggregateOverlayDiagrams need help
  - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
b4f8b01 
- hacked in the new structure on client side
  - but no (working) year selector mechanism yet

TODO
- need to worry about the costService
- AggregateOverlayDiagrams need help
  - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
916ec6f 
- basic year selector working
  - TODO to restrict initial selection
  - TODO flip back to next best year if data missing
- TODO
  - AggregateOverlayDiagrams need help
    - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
9b9db30 
- basic year selector working
  - TODO to restrict initial selection
  - flips back to next best year if data missing
- TODO
  - AggregateOverlayDiagrams need help
    - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
53c73c1 
- basic year selector working
  - restricts initial selection
  - flips back to next best year if data missing
- TODO all costs needs to be reactive to year selection
- TODO
  - AggregateOverlayDiagrams need help
    - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
b5ee18c 
- basic year selector working
  - all costs are reactive to year selection
- TODO
  - AggregateOverlayDiagrams need help
    - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
128b1a9 
- removing dead code
- TODO
  - AggregateOverlayDiagrams need help
    - did some hacking on AggregateOverlayDiagramService::208

finos#6508
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 26, 2023
@davidwatkins73
Adding a year selector to the cost sections
2e3a742 
- fixing aggregateOverlayDiagram

finos#6508
@davidwatkins73 davidwatkins73 mentioned this issue Mar 26, 2023
Merged
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Mar 26, 2023
@davidwatkins73
Copy link
Member Author

image

@davidwatkins73 davidwatkins73 modified the milestones: done : 1.48, 1.48 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Milestone
1.48
Development

No branches or pull requests
1 participant
@davidwatkins73