Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey Template: Misleading error message upon creation when user/person cannot be found #6480

Closed
davidwatkins73 opened this issue Mar 7, 2023 · 0 comments
Closed

Survey Template: Misleading error message upon creation when user/person cannot be found #6480

davidwatkins73 opened this issue Mar 7, 2023 · 0 comments
Assignees
@davidwatkins73
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Milestone
1.49

Comments

@davidwatkins73
Copy link
Member

Description

Mentioned as part of #6477

This happens when a user attempts to create a survey template but has no linked person record. We are expecting the username to match a (live) email address in the person table. This needs to be changed as part of #6477.

However the failure is mis-reported as a non-uniqueness violation.

Suspect the code simply assumes this is the cause rather than checking.

Waltz Version

1.47.1

Steps to Reproduce

  1. Create a new user (which does not match any person records)
  2. Attempt to create a survey template
  3. Mis-reports the error as a uniqueness violation

Expected Result

No response

Actual Result

No response
@davidwatkins73 davidwatkins73 added the bug Defect affecting the currently released version of Waltz label Mar 7, 2023
@davidwatkins73 davidwatkins73 added this to the todo : 1.48 milestone Mar 7, 2023
@davidwatkins73 davidwatkins73 self-assigned this Apr 30, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Apr 30, 2023
@davidwatkins73
Clarified error message when survey template cannot be saved
59e845d 
finos#6480
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Apr 30, 2023
@davidwatkins73
Clarified error message when survey template cannot be saved
82e6338 
finos#6480
@davidwatkins73 davidwatkins73 mentioned this issue Apr 30, 2023
Merged
@jessica-woodland-scott-db jessica-woodland-scott-db added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label May 2, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.49, 1.49 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Projects
None yet
Milestone
1.49
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db