Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support (one level) hierarchy on rating scheme items #6360

Closed
11 tasks done
davidwatkins73 opened this issue Jan 5, 2023 · 1 comment
Closed
11 tasks done

Support (one level) hierarchy on rating scheme items #6360

davidwatkins73 opened this issue Jan 5, 2023 · 1 comment
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes QoL Quality of Life
Milestone

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented Jan 5, 2023

Description

We would like to be able to support rating schemes that look like:

  • group a
    • item 1a
    • item 2a
  • group b
    • item 1b

Implementation notes:

  • The groups are not selectable (although they may toggle a select/deselect all in MVA's)
  • Items must have unique names per scheme regardless of groups

Tasks:

  • enforce uniqueness of item names (per scheme)
  • enforce uniqueness of assessment definition names
  • add external_id to rating_scheme
  • increase column size of rating_scheme_item - code
    • Need to be able to support more than one chars worth of options, (i.e. country codes). This may have unforeseen knock-ons, so proceed with caution :)
  • add rating_group column to rating_scheme_item
  • UI changes (using opt-groups, see comment below)
    • Mostly around edit
    • Perhaps on the detail view when clicking on an assessment
    • Measurable ratings editor / display
  • Admin screens (item edit)

We do not intend to:

  • Show in list view
  • Show in report grid
  • Include in exports (?)

Resourcing

We would like to add this request to the Waltz team's feature backlog

@davidwatkins73 davidwatkins73 added noteworthy probably worth mentioning in release notes DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database QoL Quality of Life labels Jan 5, 2023
@davidwatkins73 davidwatkins73 added this to the todo : 1.47 milestone Jan 5, 2023
@davidwatkins73
Copy link
Member Author

Example of opt-groups:

<select>
        <optgroup label="Programming Languages">
            <option value="C">C</option>
            <option value="C++">C++</option>
            <option value="Java">Java
        </optgroup>
        <optgroup label="Scripting Language">
            <option value="JavaScript">JavaScript</option>
            <option value="PHP">PHP</option>
            <option value="Shell">Shell</option>
        </optgroup>
</select>

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jan 5, 2023
 - rating_scheme
 - rating_scheme_item
 - assessment_definition

Added rating group to rating_scheme_item

Added external_id to rating_scheme

Increased size of code column on rating_scheme_item

finos#6360
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jan 5, 2023
 - rating_scheme
 - rating_scheme_item
 - assessment_definition

Added rating group to rating_scheme_item

Added external_id to rating_scheme

Increased size of code column on rating_scheme_item

finos#6360
@davidwatkins73 davidwatkins73 modified the milestones: todo : 1.47, wip : 1.47 Jan 5, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jan 5, 2023
- updated DAO and model
- updated admin UI

finos#6360
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jan 5, 2023
- updated editor UI

finos#6360
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jan 5, 2023
- fixed checkmark on measurable rating picker
- updated database column to be varchar not char so as to avoid padding

finos#6360
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Jan 6, 2023
@davidwatkins73 davidwatkins73 modified the milestones: wip : 1.47, done : 1.47 Jan 6, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.47, 1.47 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes QoL Quality of Life
Projects
None yet
Development

No branches or pull requests

1 participant