Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurables: optimise search for large trees #6202

Closed
davidwatkins73 opened this issue Aug 31, 2022 · 1 comment
Closed

Measurables: optimise search for large trees #6202

davidwatkins73 opened this issue Aug 31, 2022 · 1 comment
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Milestone
1.47

Comments

@davidwatkins73
Copy link
Member

Description

In measurable-tree (used by measurable-category-list) there is a bit of code which filters the hierarchy based on user input (vm.searchTermsChanged) . If the search returns lots of hits the tree control attempts to redraw with the relevant paths open.
This kills the browser if there are too many 'hits'.

This issue should investigate using a notification back to the user (toaster or inline message) warning them that their search is too vague and needs refinement.

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the QoL Quality of Life label Aug 31, 2022
@davidwatkins73 davidwatkins73 added this to the todo : 1.44 milestone Aug 31, 2022
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Aug 31, 2022 •
edited
Loading

Places needing fixing:

  • Measurable Category homepage
  • Measurable Category edit page
  • Measurable rating editor
  • Spindle (Entity Relationship Editor)

@davidwatkins73 davidwatkins73 modified the milestones: todo : 1.46, 1.45.2 Nov 22, 2022
@davidwatkins73 davidwatkins73 modified the milestones: 1.45.2, todo : 1.46 Nov 29, 2022
@davidwatkins73 davidwatkins73 self-assigned this Dec 5, 2022
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jan 12, 2023
@db-waltz
Optimize tree searches
ad87bda 
- specifically we optimize the expanded nodes on the tree to prevent a massive load on the client when redrawing trees

finos#6202
#CTCTOWALTZ-2625
@davidwatkins73 davidwatkins73 mentioned this issue Jan 12, 2023
Merged
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Jan 12, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.47, 1.47 Feb 1, 2023
@davidwatkins73 davidwatkins73 mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Projects
None yet
Milestone
1.47
Development

No branches or pull requests
1 participant
@davidwatkins73