-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugin @finos/perspective-viewer-datagrid
#954
Conversation
"license": "Apache-2.0", | ||
"dependencies": { | ||
"@finos/perspective": "^0.4.2", | ||
"@finos/perspective-viewer": "^0.4.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are older versions of "@finos/perspective" and "@finos/perspective-viewer", mind updating to latest @texodus?
|
||
// The largest size virtual <div> in (px) that Chrome can support without | ||
// glitching. | ||
const CHROME_FUCKUP_LIMIT = 10000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a different name here?
} | ||
|
||
constructor(container, table) { | ||
// super(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this super()
important
a3203e7
to
90fa809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thanks!
Introduces a new plugin
@finos/perspective-viewer-datagrid
, which will eventually replace@finos/perspective-viewer-hypergrid
.Example Custom Styles
Example Superstore
While similar to Hypergrid in UX, Datagrid is
<table>
<div>
at "real" dimensions, which allows native scrollbars, natural responsiveness topagedown
andspacebar
scrolling, etc..@finos/perspective-viewer-hypergrid
).table
:td
,tr
,thead
,tbody
, with some perspective metadata to E N G A G E analytics.<table>
- screen readers etc. work out of the box.@finos/perspective-viewer-hypergrid
.The new styling API simply inlines a
<table>
element into the light DOM as a child of your<perspective-viewer>
, allowing you to style with simple CSSCombined with simple
CustomEvent
,"perspective-datagrid-update"
, complex styling, embedded images, charts and controls are simple and natural to implement, similar to a traditional static HTML table.There are a few known issues, and some notable missing features:
editable
orselectable
support yet.