Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with np.int_ on Windows, handle missing __INDEX__ #943

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Deal with np.int_ on Windows, handle missing __INDEX__ #943

merged 4 commits into from
Feb 24, 2020

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 22, 2020 •
edited
Loading

@timkpaine timkpaine added bug Concrete, reproducible bugs Python cla-present and removed cla-present labels Feb 22, 2020
@timkpaine timkpaine requested a review from sc1f February 23, 2020 00:53
@timkpaine timkpaine mentioned this pull request Feb 23, 2020
Closed
sc1f
sc1f approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for the fix.

@timkpaine timkpaine mentioned this pull request Feb 23, 2020
Closed
@texodus
Copy link
Member

texodus commented Feb 24, 2020

Thanks for the PR!

@texodus texodus merged commit e95f4c4 into master Feb 24, 2020
@texodus texodus deleted the win_npint branch February 24, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc1f sc1f sc1f approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy int defaults to int32 on Windows, int64 on *nix
4 participants
@timkpaine @texodus @sc1f @finos-admin