Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget title in perspective-workspace #934

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Conversation

zemeolotu
Copy link
Contributor

@zemeolotu zemeolotu commented Feb 19, 2020

This PR fixes a bug when you duplicate an untitled widget.

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Feb 20, 2020
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@@ -25,7 +25,7 @@
"test:run": "jest --rootDir=. --config=../perspective-test/jest.config.js --color 2>&1",
"test:unit": "jest --color --config=./config/jest.unit.config.js 2>&1",
"test:integration": "jest --color --config=./config/jest.integration.config.js 2>&1",
"watch": "webpack --color --watch --config config/watch.config.js"
"watch": "PSP_DEBUG=1 webpack --color --watch --config config/watch.config.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops - didn't think watch task works here anyway due to lack of babel-loader?

@texodus texodus merged commit ce6603d into master Feb 24, 2020
@texodus texodus deleted the workspace-title-fix branch February 24, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants