Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perspective-workspace initialize bug #924

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix perspective-workspace initialize bug #924

merged 1 commit into from
Feb 24, 2020

Conversation

zemeolotu
Copy link
Contributor

This PR fixes a bug where perspective-workspace fails during page load.

The error only happens when perspective-workspace is declared in the html (see workspace example)

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Feb 18, 2020
texodus
texodus approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 3ca9087 into master Feb 24, 2020
@texodus texodus deleted the workspace-fix branch February 24, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin