Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'perspective-select' event to @finos/perspective-viewer-hypergrid #894

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

zemeolotu
Copy link
Contributor

This PR adds a perspective-select fired by perspective-viewer-hypergrid. The event is fired only when selectable is set on the perspective-viewer.

It's different from the perspective-click event as it provides extra information about the selection state of the row clicked.

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Feb 2, 2020
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 1d9a997 into master Feb 2, 2020
@texodus texodus deleted the hypergrid-select-event branch February 2, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants