Optional @finos/perspective-webpack-plugin
#870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
@finos/perspective
default to export a WASM-inlined build, which inlines the WASM payload as base64 and the WebWorker as an inline string. With this change, by default:@finos/perspective*
modules will build without@finos/perspective-webpack-plugin
.But:
So by default, perspective will now be easier to install, but output a slightly worse build. By using
@finos/perspective-webpack-plugin
, the build will still work as currently, outputting the independentperspective.wasm.worker.js
andpsp.async.wasm
, with no performance impact.This is intended to address many recent support questions about build errors for new users e.g. #860 #857
On the side, this also makes
perspective-test
output screenshots from different architectures to separate folders, which makes testing across docker/local puppeteer much more convenient.