Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling for pivoted hypergrid #866

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Fix scrolling for pivoted hypergrid #866

merged 2 commits into from
Jan 13, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jan 8, 2020

Previously, pivoted grids showing a collapsed tree (smaller than the viewport) would cause the scrollbar to disappear and not re-appear, even when tree expansion causes content to overflow the viewport. This PR triggers a scrollbar redraw whenever the number of rows in hypergrid changes.

@sc1f sc1f added bug Concrete, reproducible bugs JS labels Jan 8, 2020
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - great test coverage!

@texodus texodus merged commit 55cc274 into master Jan 13, 2020
@texodus texodus deleted the fix-pivot-grid branch January 13, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants