Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages from C++ #862

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Improved error messages from C++ #862

merged 1 commit into from
Jan 7, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jan 7, 2020

This PR makes the error messages from the C++ engine more helpful to users, especially where column names are involved - the offending column name is now included in the error message.

@sc1f sc1f added internal Internal refactoring and code quality improvement C++ labels Jan 7, 2020
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit ffd0ed2 into master Jan 7, 2020
@texodus texodus deleted the error-msg branch September 3, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants