Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js table unpin #844

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Node.js table unpin #844

merged 1 commit into from
Dec 16, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Dec 13, 2019

Fixes #841

  • Removes the empty view() which kept hosted table alive. <perspective-viewer> no longer deletes it's table when it is itself deleted, so this is not default deleted (though it can still be explicitly deleted remotely - probably something to change later).
  • Adds on_delete callbacks for both, unhosting objects when they are deleted.
  • Adds eject_table() and eject_view() methods.

@andyferris
Copy link

Awesome, thanks @texodus!

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Dec 16, 2019
@texodus texodus merged commit 3235296 into master Dec 16, 2019
@texodus texodus deleted the table-unpin branch December 16, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to delete a hosted table?
5 participants