Asynchronously process updates when running in Tornado #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
Dec 11, 2019
|
Thanks for the PR! |
texodus
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an integration between
perspective-pythonand the Tornado event loop, namely allowing Perspective to call_processon updates (an expensive operation) asynchronously.When using
PerspectiveTornadoHandler, the defaultqueue_processmethod is replaced with a version that usestornado.ioloop.IOLoop.current(), and the_processcall becomes a callback for the next loop iteration.This should also allow for deeper integration with other event loop structures, which would implement their own version of
queue_process, and then call_set_queue_processon an instance ofPerspectiveManager. The tables under management (and future tables hosted on the manager instance) will now call the customqueue_processmethod. This structure also allows for manager instances that use the event loop and other instances that do not use the event loop all in the same runtime.Various tests have been added for the async functionality.