Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget fixes for resizing, TS typings, boolean columns #826

Merged
merged 7 commits into from
Nov 27, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Nov 26, 2019

  • Fix widget resize by calling notifyResize properly
  • Fix typing for Perspective Viewer by making table options optional
  • Fix exception thrown when string booleans ("True", "False") were passed into Perspective
  • Make sure column pivots on booleans return true or false as their column name, not 0/1

@sc1f sc1f changed the title Fix for #825 - widget resizes properly Widget fixes for resizing, TS typings, boolean columns Nov 27, 2019
@texodus
Copy link
Member

texodus commented Nov 27, 2019

Thanks for the PR! Looks good!

@texodus texodus merged commit f2d7dc2 into master Nov 27, 2019
@texodus texodus deleted the fix-widget-resize branch November 27, 2019 21:21
@texodus texodus added bug Concrete, reproducible bugs enhancement Feature requests or improvements and removed enhancement Feature requests or improvements labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants