Default to int64 in Python3, add long and unicode to schema and type inference
#821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc1f
changed the title
long and unicode to schema and type inferrencelong and unicode to schema and type inference
|
Looks good, thanks for the PR! |
texodus
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our inference check to infer int32s in python 2 and int64 in python 3. Additionally, it allows
longandunicodeto be used in schemas;longmaps to int64, andunicodemaps to string.Actual storage semantics of the values are not changed, so the limit for numeric types remains at 64 bits. Passing in a value that overflows int64 is undefined behavior.
Additionally wraps the call to
iterto generate more meaningful errors when assessing the type of a dataset.