Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compute() to dynamically show/hide sidebar computation panel #748

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Sep 30, 2019

Because computed columns is not yet implemented in the Python API, make sure the viewer does not render the computation sidebar when Table.compute() returns false.

@codecov-io
Copy link

Codecov Report

Merging #748 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   91.82%   91.69%   -0.13%     
==========================================
  Files          49       49              
  Lines        3093     3095       +2     
==========================================
- Hits         2840     2838       -2     
- Misses        253      257       +4
Impacted Files Coverage Δ
perspective/table/_date_validator.py 86.84% <0%> (-7.9%) ⬇️
perspective/table/table.py 94% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249b10a...4efea02. Read the comment docs.

@texodus
Copy link
Member

texodus commented Oct 2, 2019

Looks good, thanks for the PR!

@texodus texodus merged commit 2cec28c into master Oct 2, 2019
@texodus texodus deleted the py-computed branch December 14, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants