-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python improvements + refactor #730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 92.29% 92.37% +0.08%
==========================================
Files 59 61 +2
Lines 2141 2703 +562
==========================================
+ Hits 1976 2497 +521
- Misses 165 206 +41
Continue to review full report at Codecov.
|
ffe79ac
to
4842e2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to go back through and update the readme and docs to consolidate the instructions for building the node and c++ into one unified set
|
||
### `perspective-python:table` | ||
|
||
To build `perspective-python:table` from source, you'll need the following C++ dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all one package now
Thanks for the PR! Looks great! |
This PR irons out a few errors with the Python API and makes it more consistent with the Javascript API as well as the results expected by the viewer and associated plugins.
Notable changes:
row_pivots
andcolumn_pivots
use underscores, thus following the core API