Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python improvements + refactor #730

Merged
merged 13 commits into from
Sep 22, 2019
Merged

Python improvements + refactor #730

merged 13 commits into from
Sep 22, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Sep 19, 2019

This PR irons out a few errors with the Python API and makes it more consistent with the Javascript API as well as the results expected by the viewer and associated plugins.

Notable changes:

  • update_callback, remove_update, on_delete, on_update have been implemented
  • data accessor API updated to be consistent with JS
  • bugs in to_format have been fixed
  • row_pivots and column_pivots use underscores, thus following the core API

python/perspective/perspective/table/_callback_cache.py Outdated Show resolved Hide resolved
python/perspective/perspective/table/_data_formatter.py Outdated Show resolved Hide resolved
python/perspective/perspective/table/table.py Outdated Show resolved Hide resolved
python/perspective/perspective/table/table.py Outdated Show resolved Hide resolved
python/perspective/perspective/table/table.py Show resolved Hide resolved
python/perspective/perspective/table/view.py Show resolved Hide resolved
python/perspective/perspective/table/view.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #730 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   92.29%   92.37%   +0.08%     
==========================================
  Files          59       61       +2     
  Lines        2141     2703     +562     
==========================================
+ Hits         1976     2497     +521     
- Misses        165      206      +41
Impacted Files Coverage Δ
perspective/table/view.py 80.95% <0%> (-16.07%) ⬇️
perspective/tests/table/test_update.py 88.76% <0%> (-11.24%) ⬇️
perspective/table/view_config.py 96.42% <0%> (-3.58%) ⬇️
perspective/tests/table/test_view.py 98.46% <0%> (-1.54%) ⬇️
perspective/table/table.py 91% <0%> (-1.16%) ⬇️
perspective/tests/table/test_to_format.py 100% <0%> (ø) ⬆️
perspective/table/_data_formatter.py 95.23% <0%> (ø) ⬆️
perspective/tests/table/test_table.py 100% <0%> (ø) ⬆️
perspective/table/_exception.py 100% <0%> (ø)
perspective/table/_callback_cache.py 90.9% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4897c3...81172af. Read the comment docs.

@finos finos deleted a comment from finos-admin Sep 20, 2019
@finos finos deleted a comment from timkpaine Sep 20, 2019
@sc1f sc1f force-pushed the py-fix branch 2 times, most recently from ffe79ac to 4842e2f Compare September 20, 2019 20:48
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to go back through and update the readme and docs to consolidate the instructions for building the node and c++ into one unified set


### `perspective-python:table`

To build `perspective-python:table` from source, you'll need the following C++ dependencies:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all one package now

@finos finos deleted a comment from finos-admin Sep 21, 2019
@finos finos deleted a comment from finos-admin Sep 21, 2019
@texodus
Copy link
Member

texodus commented Sep 22, 2019

Thanks for the PR! Looks great!

@texodus texodus merged commit b80912b into master Sep 22, 2019
@texodus texodus deleted the py-fix branch September 22, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants