Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore highcharts on phosphor/jlab until d3 is complete #608

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Conversation

timkpaine
Copy link
Member

No description provided.

@texodus
Copy link
Member

texodus commented Jun 6, 2019

@finos/perspective-viewer-d3fc is now the default charting plugin for @finos/perspective-viewer - there are no more changes coming for this that will make this any more "complete" a transition than it is currently, e.g. d3_y_line is never going to be "promoted" to y_line. You should not generally import both @finos/perspective-viewer-highcharts and @finos/perspective-viewer-d3fc in the same app -

  • You are massively increasing your payload size for identical plugins
  • You have 2 identical plugins presented to he user with slightly different names.

I can merge this for now to deal with he fact that the perspective-python package lags master, but having these releases coordinated and tested in the same repository is a substantially better way to handle this in the future.

@texodus texodus merged commit e98254e into master Jun 6, 2019
@texodus texodus deleted the highcharts branch June 6, 2019 17:04
@timkpaine
Copy link
Member Author

"d3_y_line is never going to be "promoted" to y_line"

If this is the case, then y_line and all others should be deleted and renamed to highcharts_y_line to avoid confusion. perspective-python is not lagging in this case, it is simple that y_line and others no longer exist as names when they absolutely should be (most users don't care about the underlying js library). If we instead make it <lib>_y_line then i can enforce defaults in python

@texodus
Copy link
Member

texodus commented Jun 6, 2019

Even better - @finos/perspective-viewer-highcharts is already marked deprecated.

@timkpaine
Copy link
Member Author

But there are missing chart types for d3

@texodus
Copy link
Member

texodus commented Jun 6, 2019

Only xy_line currently - highcharts is e.g. missing candlestick and ohlc

@timkpaine
Copy link
Member Author

Does it have y_bar I didn't see

@timkpaine timkpaine changed the title Restore highchairs on phosphor/jlab until d3 is complete Restore highcharts on phosphor/jlab until d3 is complete Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants