Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row delta supports addition, delete, non-contiguous updates #582

Merged
merged 5 commits into from
May 16, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented May 16, 2019

This PR fixes my previous implementation of calculating updated row indices:

  • 0-sided contexts save changed primary keys to a set, and when get_row_delta is called, transforms the primary keys to row indices and returns the changed rows.
  • get_row_delta no longer supports the bidx and eidx options, and will return deltas for all rows on default.
  • get_row_delta in the View C++ class transforms the hopscotch set into a vector for interoperability with Emscripten and Javascript.
  • New tests have been added for row delta that test row addition, deletion, and non-contiguous updates.
  • Fix prettify errors in benchmark suite, and replace localhost URL with the Docker host URL.

@texodus texodus merged commit bd2c60f into master May 16, 2019
@texodus texodus deleted the row-delta branch May 16, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants