Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added y-axis split to area, y-scatter and column charts #581

Merged
merged 4 commits into from
May 22, 2019

Conversation

andy-lee-eng
Copy link
Contributor

@andy-lee-eng andy-lee-eng commented May 16, 2019

Added y-axis split to area, y-scatter and column charts.
Column chart needs to blank-out instead of filter the data for each y-axis, and also needs to harmonise the origin of the domain on each side (to make the bars line up).
Use axisFactory provided component and tick formatter.

Includes provision of "right" axis components, and using them for the alternate y-axis width, decorate and tick-formatting options.
Column chart needs to blank-out instead of filter the data for each y-axis, and also needs to harmonise the origin of the domain on each side (to make the bars line up).
@andy-lee-eng andy-lee-eng changed the title Feature/dual y other charts Added y-axis split to area, y-scatter and column charts May 16, 2019
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels May 16, 2019
If you clicked on the legend to hide the series that is in the right-hand y-axis, the domain-match function would actually break the left-hand domain, causing a load of console errors (and the left-hand series wouldn't display).
@texodus texodus merged commit 4140828 into finos:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants