Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dual y axis POC #564

Merged
merged 10 commits into from
May 15, 2019
Merged

Conversation

matt-hooper
Copy link
Contributor

Proof of Concept Dual Y Axis just implemented for d3fc Y Line charts.

Instructions for use:

  1. Select the Y Line Chart [d3_y_line]
  2. Add at least two values to the chart
  3. Use the Left and Right arrows to move values from one axis to the other:

Single Axis
image

Dual Axis
image

andy-lee-eng and others added 5 commits May 3, 2019 16:40
Uses a decorated chart to fill in the 5th grid column with a second y-axis, and render both sets of series with their corresponding scales.
Splitting by name is necessary when we have a split-by value, because there are multiple series per mainValue, and we can't identify them by index.

Color is applied when there isn't a split-by, but can't be when there is because there are several colours.
The Zoomable component was replacing the decorator function, so we need to chain them
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels May 7, 2019
Update results.json to reflect Scatter name change
@andy-lee-eng
Copy link
Contributor

We created this PR as a proof of concept of the dual-y-axis, to demonstrate how we thought the UI could work. We wanted to get some feedback on this before we extended it to other charts. Please give it a try if you can.

As we didn't include it in the main PR (the treemap and other features), that also means that this PR includes all the commits that are also in that one. In fact, there are only 4 commits relating to dual-y-axis:

Implemented dual-y axis on line chart
Split by name instead of index, and add color
Use d3fc axis component, instead of d3
Fixed issue with date x-axis

@texodus
Copy link
Member

texodus commented May 15, 2019

Thanks for the PR!

This is a really elegant implementation of this feature, sets a good precedent for how we should implement plugin-specific configuration going forward without increasing the UX complexity of the widget itself.

@texodus texodus merged commit 302b8e8 into finos:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants