Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3fc default #551

Merged
merged 7 commits into from
Apr 30, 2019
Merged

D3fc default #551

merged 7 commits into from
Apr 30, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Apr 22, 2019

This commit prepares D3fc to take over as the default charting plugin for perspective-viewer, and makes some changes to the plugin architecture to make this transition a bit easier. Charts in the perspective-viewer-d3fc and perspective-viewer-highcharts modules can now be imported individually, ala

import "@jpmorganchase/perspective-viewer-d3fc/bar";
import "@jpmorganchase/perspective-viewer-highcharts/treemap";

The plugin human-readable names have been simplified, and a new name reconciliation method has been added to handle qualifiying e.g. "X Bar" with "X Bar [x_bar]" and "X Bar [d3_x_bar]" when the same chart type is imported twice.

This commit also adds the d3fc plugin to the docs.

@texodus texodus force-pushed the d3fc-default branch 3 times, most recently from a7b7c75 to a31b133 Compare April 27, 2019 00:25
@texodus texodus merged commit c422f4a into master Apr 30, 2019
@texodus texodus deleted the d3fc-default branch April 30, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant