Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make row titles configurable via plugin API #512

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Apr 2, 2019

Row titles for plugins are now part of the plugin API, via the names property of the initial config entry.

Example from D3FC:

ohlc.plugin = {
    type: "d3_ohlc",
    name: "[d3fc] OHLC Chart",
    max_size: 25000,
    initial: {
        type: "number",
        count: 4,
        names: ["Open", "Close", "High", "Low"]
    }
};

@texodus
Copy link
Member Author

texodus commented Apr 2, 2019

@matt-hooper @DevAndyLee I modified the D3FC plugin to use this new API, and removed the perspective-view.less file you had to inject in the <perspective-viewer> shadow dom. Let me know if these changes look good to y'all!

Copy link
Contributor

@andy-lee-eng andy-lee-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@matt-hooper
Copy link
Contributor

No issue from me.
Thanks

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Apr 2, 2019
@texodus texodus merged commit c9585ec into master Apr 2, 2019
@texodus texodus deleted the plugin-row-names branch April 2, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants