Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_update delta calculations are now lazy #495

Merged
merged 1 commit into from
Mar 26, 2019
Merged

on_update delta calculations are now lazy #495

merged 1 commit into from
Mar 26, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 26, 2019

As it says on the tin. This changes the default on_update API to invoke its callback function with no arguments. The previous behavior, which called the callback with the modified rows (but only worked correctly for 0-sided contexts, and performs poorly) can be preserved via

view.on_update(callback, {mode: "rows"});

Future updates will use the new mode optional parameter to implement a more granular update delta API, as well as improve the delta calculation performance penalty.

@texodus texodus merged commit ba2b5d9 into master Mar 26, 2019
@texodus texodus deleted the new-update-api branch March 26, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant