Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3FC fixes #474

Merged
merged 3 commits into from
Mar 7, 2019
Merged

D3FC fixes #474

merged 3 commits into from
Mar 7, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 7, 2019

This commit enabled D3FC integration tests in Travis and the default test runner, and fixes a few minor issues that the test caught -

  • Fixes NaN sizing bug, from this commit which had modified the signature of domain() in mainAxis.js, but not for the size property of scatter charts.
  • Applies withOutOpacity() modification to line charts, which had become hard to see with the introduction of chart opacity.

Copy link
Contributor

@andy-lee-eng andy-lee-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@texodus
Copy link
Member Author

texodus commented Mar 7, 2019

@DevAndyLee Thanks for the review!

@texodus texodus merged commit 244ac2a into master Mar 7, 2019
@texodus texodus deleted the d3fc-fixes branch March 7, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants