Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression on view expand #445

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Fix regression on view expand #445

merged 3 commits into from
Feb 22, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Feb 22, 2019

  • View should no longer be able to expand for indices past the number of row pivots.
  • Add tests to confirm expand works as intend
  • Refactor view.cpp to explicitly specialize expand(), collapse(), and set_depth()

@texodus
Copy link
Member

texodus commented Feb 22, 2019

Thanks for the PR!

@texodus texodus merged commit d0e63ff into master Feb 22, 2019
@texodus texodus deleted the fix-expand branch February 22, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc1f @texodus @fixanoid