Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mac failures on travis, have travis fail fast #428

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Allow mac failures on travis, have travis fail fast #428

merged 1 commit into from
Feb 13, 2019

Conversation

timkpaine
Copy link
Member

This PR does two things:

  • the Mac image on travis hangs occasionally. Since several of us are developing full time on MacBooks anyway, we can allow this one to fail.
  • Makes travis fail fast, so we dont waste resources when people need to iterate on PRs.

@timkpaine timkpaine added enhancement Feature requests or improvements tests labels Feb 11, 2019
@timkpaine timkpaine closed this Feb 12, 2019
@timkpaine timkpaine deleted the allow_mac_fail branch February 12, 2019 17:06
@timkpaine timkpaine restored the allow_mac_fail branch February 12, 2019 17:06
@timkpaine timkpaine reopened this Feb 12, 2019
@texodus
Copy link
Member

texodus commented Feb 13, 2019

Thanks for the PR! Looks good

@texodus texodus merged commit ec6722b into finos:master Feb 13, 2019
@timkpaine timkpaine deleted the allow_mac_fail branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus