Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output CJS module bundles for perspective-viewer packages #391

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

LukeSheard
Copy link
Contributor

Output a slim version of the perspective viewer packages which is targeted when consuming the package from a module bundler (e.g. webpack, rollup, etc.)

  1. Reduce the scope creep of Add pre-compiled JavaScript artifacts for Perspective package #378
  2. unminified, precompiled assets, will be quicker for Webpack to parse and compile than the UMD builds.
  3. It will prevent duplication of dependencies of perspective-* packages when built together - leading to smaller bundle sizes for consumers.

@texodus
Copy link
Member

texodus commented Jan 23, 2019

Thanks for the PR! Discussed offline, this is good to merge plus some future additions

@texodus texodus merged commit e01856f into master Jan 23, 2019
@texodus texodus deleted the npm-cjs branch January 23, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants