Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove boost::format #374

Merged
merged 2 commits into from
Jan 11, 2019
Merged

remove boost::format #374

merged 2 commits into from
Jan 11, 2019

Conversation

timkpaine
Copy link
Member

for both size reasons, and because it causes issues on the (future) arrow build.

@timkpaine timkpaine requested a review from sc1f January 10, 2019 15:51
sc1f
sc1f approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@timkpaine timkpaine added C++ JS enhancement Feature requests or improvements labels Jan 10, 2019
@texodus
Copy link
Member

texodus commented Jan 11, 2019

Thanks for the PR!

@texodus texodus merged commit f7f8f4b into finos:master Jan 11, 2019
@timkpaine timkpaine deleted the boost_format branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc1f sc1f sc1f approved these changes

Assignees
No one assigned
Labels
C++ enhancement Feature requests or improvements JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timkpaine @texodus @sc1f