sdist: include data_dir again #2852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjakubowski
force-pushed
the
hotfix/sdist-data
branch
3 times, most recently
from
41028ea
to
bf08cab
Compare
The data dir was accidentally removed from the sdist in 053abcd. Our Maturin version is currently incorrectly packaging the license files under `.dist-info/license_files`, when it should be (according to PEP 639) in `.dist-info/licenses`. This has been fixed in newer versions of Maturin. Update the CI test to check in both places so that it won't break when we update Maturin. Signed-off-by: Tom Jakubowski <[email protected]>
tomjakubowski
force-pushed
the
hotfix/sdist-data
branch
from
bf08cab
to
a919b3a
Compare
|
This hotfix was incorporated into the 3.1.5 release commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data dir was accidentally removed from the sdist in 053abcd