Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for handling nulls in pivot columns. #280

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

deepankarsharma
Copy link
Contributor

No description provided.

@texodus
Copy link
Member

texodus commented Oct 15, 2018

Thanks for the PR! The fix is much appreciated.

The tests seem to be failing to due a behavior change in floating point rounding - I assume this was not intentional and just an artifact of the order of operations for aggregates changing slightly, and is certainly inconsequential. A few notes for the future:

  • There are alot of changes in this one commit - formatting changes, some references to a C++ test file not included in the PR, removal of the PSP_PARALLEL_FOR blocks, etc. Breaking this up into smaller commits/multiple PRs would assist me in merging these in a timely manner, as small commits are much easier to review.
  • The tests need to pass - not just as a matter of principal, but because we have the repository configured to not allow merges on branches that fail on Travis CI. The puppeteer tests need documentation on how to use them certainly. You can review the modified screenshots/ directory to see the failures (see screenshot), and update these hashes automatically with the WRITE_TESTS=1 npm run test environment flag.

screen shot 2018-10-14 at 11 47 50 pm

Otherwise, changes look good! I will fix the test hashes and merge out-of-band.

@texodus texodus merged commit a29ba58 into finos:master Oct 15, 2018
@deepankarsharma
Copy link
Contributor Author

Thanks for the pointers on how to auto update the hashes. Will try to commit work in smaller increments in the future.

@texodus texodus added the bug Concrete, reproducible bugs label Oct 15, 2018
@deepankarsharma deepankarsharma deleted the null_pivot_patch branch October 16, 2018 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants