Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Settings Panel UI Tweaks #2421

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

ada-x64
Copy link
Contributor

@ada-x64 ada-x64 commented Nov 8, 2023

Based on #2399 for column settings panel changes.

  • Hide edit button for cols with no styles or attrs
  • Hide the style tab unless needed (hack!)
    • In order to do this in a sane way, we need to update the plugin_attributes API.
  • Add a size trap for column settings panel width
  • Update column settings panel title to be less verbose
  • Update tests

@ada-x64 ada-x64 changed the title Update Expressions API to handle {name, expr} format + backwards compat Column Settings Panel UI Tweaks Nov 8, 2023
@ada-x64 ada-x64 force-pushed the bugs/column-settings-sidebar-ui branch from f842544 to 377c41a Compare November 9, 2023 15:06
Hide edit button for cols with no styles or attrs
Hide the style tab unless needed (hack!)
Add a size trap for column settings panel width
Update column settings panel title to be less verbose
Update tests
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 10bfe2c into finos:master Nov 17, 2023
13 checks passed
@texodus texodus added the bug Concrete, reproducible bugs label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants