Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New themes Gruvbox and Dracula + UI performance improvements #2393

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Oct 17, 2023

  • Adds 3 new color themes, as a side effect of internal refactoring to make theming easier:

    Gruvbox Light
    Screenshot 2023-10-17 at 4 59 54 PM

    Gruvbox Dark
    Screenshot 2023-10-17 at 5 00 04 PM

    Dracula
    Screenshot 2023-10-17 at 5 00 16 PM

  • Fixed a resize issue which may cause part of the inactive columns menu to be clipped after resizing the browser.

  • Upgraded to Yew 0.21, plus several non-breaking dependencies.

  • Fixes an issue which caused the sidebar to alter width as the config is changed, due to the underlying virtual ScrollPanel losing its calculated state on re-render. Perspective supports datasets with many thousands of columns if necessary, so drawing/measuring all column names to calculate the column selector width is not possible - rather, the width is recalculated on scroll and may grow, but wont shrink generally. This state was kept in component state, and a refactor caused this component's parent to re-create the component on change due to a wrapped if conditional block.

    Old:

    Screen.Recording.2023-10-17.at.5.20.55.PM.mov

    New:

    Screen.Recording.2023-10-17.at.5.21.14.PM.mov

@texodus texodus added the enhancement Feature requests or improvements label Oct 17, 2023
@texodus texodus force-pushed the fix-dimension-bug branch 2 times, most recently from 097907e to 9ee76f0 Compare October 18, 2023 01:37
@texodus texodus merged commit 1369100 into master Oct 18, 2023
13 checks passed
@texodus texodus deleted the fix-dimension-bug branch October 18, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant