Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null fix #233

Merged
merged 5 commits into from
Sep 12, 2018
Merged

Null fix #233

merged 5 commits into from
Sep 12, 2018

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 11, 2018

Fixed 'null' updates and initial loads.

@deepankarsharma
Copy link
Contributor

See change to gnode_state.cpp lines 298-304 above: being able to express that is what the rest of the delta is about.

Thanks for the clarification, it was very helpful.

@texodus
Copy link
Member Author

texodus commented Sep 12, 2018

Thanks @sc1f and @neilslinger for the commits, as well as @deepankarsharma and @sl236 for reviewing!

I suspect there are more issues lurking with null support, but this is a substantial improvement already.

@texodus texodus merged commit ccce81e into master Sep 12, 2018
@texodus texodus deleted the null_fix branch September 12, 2018 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants