Fix exports field for Node.js 16 compatibility
#1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 16 implements obnoxiously verbose warnings for "deprecated" syntax in the
"exports"field ofpackage.json, where it seems to now require glob patterns and disallow path prefix aliases (which is in conflict with the up-to-datewepbackdocs). This PR "fixes" this but also removes several aliases which no longer work with this new restriction, leading to a breaking change. In summary, you must now import e.g.@finos/perspective/dist/umd/perspectiveas opposed to@finos/perspective/umd/perspectiveif you previously did the latter (which was allowed but not documented).Additionally, this PR normalizes the
perspective-viewer-d3fctests which had somehow drifted a few pixels on my development OSX laptop compared to Linux/CI, despitepuppeteerversion being pinned. Why? Who knows ...