Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prune 2 more python2 references #1811

Merged
merged 1 commit into from
May 19, 2022
Merged

prune 2 more python2 references #1811

merged 1 commit into from
May 19, 2022

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine marked this pull request as ready for review May 14, 2022 21:13
@timkpaine
Copy link
Member Author

Builds aren't going to run for this since its ignored, so feel free to merge without waiting:
https://github.com/finos/perspective/blob/master/azure-pipelines.yml#L25

@timkpaine timkpaine requested a review from texodus May 15, 2022 01:43
texodus
texodus approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 8bb64da into master May 19, 2022
@texodus texodus deleted the tkp/prunepy2 branch May 19, 2022 03:26
@texodus texodus added the internal Internal refactoring and code quality improvement label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus