Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perspective-workspace webpack compat #1784

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix perspective-workspace webpack compat #1784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/perspective-workspace/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ const BUILD = [
InlineCSSPlugin(),
IgnoreCSSPlugin(),
IgnoreFontsPlugin(),
NodeModulesExternal(),

// Inlining `lumino` and importing the `.ts` source saves _50kb_
NodeModulesExternal("@lumino"),
],
loader: {
".html": "text",
Expand Down
14 changes: 8 additions & 6 deletions tools/perspective-build/external.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
exports.NodeModulesExternal = function NodeModulesExternal() {
exports.NodeModulesExternal = function NodeModulesExternal(whitelist) {
function setup(build) {
build.onResolve({filter: /^[A-Za-z0-9\@]/}, (args) => {
return {
path: args.path,
external: true,
namespace: "skip-node-modules",
};
if (!whitelist || !args.path.startsWith(whitelist)) {
return {
path: args.path,
external: true,
namespace: "skip-node-modules",
};
}
});
}

Expand Down