Refactor Material Theme #178
Conversation
sc1f
commented
Aug 1, 2018
sc1f
commented
- split out common colors & fonts into variables.less
- restructure and refactor material.less & material.dark.less for readability and reduction of duplicate rule declaration.
|
make sure jlab picks these up https://github.com/jpmorganchase/perspective/tree/master/packages/perspective-jupyterlab/src/css |
|
|
||
| #divider { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
These seem to revert a commit I made on responsive-sidebar before merging, to consolidate .columns_horizontal.
There was a problem hiding this comment.
Nevermind - I misread, this works as intended.
There was a problem hiding this comment.
I didnt know you could do this...
|
|
||
| perspective-row:hover { |
There was a problem hiding this comment.
Might be worth putting style rules for perspective-computed-column in a future commit rather than here.
|
@timkpaine the Jlab css looks exactly like the compiled version of the |
|
@texodus looks like the travis/push build broke on the flaky perspective-hypergrid test. Is there a way to manually run that check again without pushing to the repo/updating the PR? |
|
@sc1f I reran the build, passed now. |
|
Looks good, thanks! |
Treat negative sunburst size values as zero
