Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two new aggtype "last minus first" and "high minus low". #1739

Closed

Conversation

shinny-yangyang
Copy link
Contributor

In some use cases, I need to display "last value minus first value of each group", but I don't find a way to get it. So I add a new aggtype "last minus first" (I copied the code snippet from "last by index" and "first").

I also add another similar aggtype "high minus low" (code snippet from "sum").

I've done some smoke testing, they seem to work fine.

@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 5, 2022

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@shinny-yangyang).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email [email protected] for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

@texodus
Copy link
Member

texodus commented Mar 6, 2022

Thanks for the PR @shinny-yangyang!

There are some issues with this, but I've made some fixes and opened a new PR #1742. This includes your commit, as well as my fixes, rebased on master to avoid a recent CI failure (#1741) - I will add additional comments there covering what I've changed and why.

Closing in favor of #1742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants