Add settings and theme to perspective-config-update DOM event and PerspectiveWidget python class
#1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
settings-python
branch
from
85325b8
to
004ac72
Compare
texodus
force-pushed
the
settings-python
branch
from
004ac72
to
b71f53f
Compare
… for `theme` and `settings` key changes
texodus
force-pushed
the
settings-python
branch
from
b71f53f
to
0b32e3d
Compare
texodus
changed the title
settings traitlet to perspective-pythonsettings and theme to perspective-config-update DOM event and PerspectiveWidget python class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
perspective-config-updateevent fired from<perspective-viewer>custom element in two ways:perspective-config-updateis now fired when either thesettingsorthemeproperty are changed, in addition to the other properties it fires for currently.event.detailproperty now includestheme,settings,pluginandplugin_config, mirroring the object returned from the.save()method.In addition, Python
traitletshave been added forsettingsandtheme, allowing them to be manipulated programmatically from thePerspectiveWidgetJupyterLab interface.Fixes #1499