Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #160 #168

Merged
merged 2 commits into from
Jul 24, 2018
Merged

fix for #160 #168

merged 2 commits into from
Jul 24, 2018

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 23, 2018 •
edited
Loading

  • does not use fake class, just uses the (currently unused) td.
  • need to do the fix on jlab plugin too

@timkpaine
Copy link
Member Author

timkpaine commented Jul 23, 2018 •
edited
Loading

original:
tmp1

this pr:
tmp2

jlab:
screen shot 2018-07-23 at 1 53 47 pm

@timkpaine timkpaine changed the title fix for the non-jupyterlab half of #160 fix for #160 Jul 23, 2018
@texodus texodus merged commit 314b4a9 into finos:master Jul 24, 2018
@texodus
Copy link
Member

texodus commented Jul 24, 2018

Looks good, thanks!

texodus pushed a commit that referenced this pull request May 13, 2019
@matt-hooper
Merge pull request #168 from redbearsam/feature/treemap_chart
4edec9e 
Feature/treemap chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus