Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perspective-workspace errors #1675

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fix perspective-workspace errors #1675

merged 2 commits into from
Dec 14, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Dec 14, 2021

  • Fixes <perspective-viewer>'s delete() method to be async, and internally acquire the draw lock. This prevents a mid-executing call to draw() from losing access to the data due to an interrupting delete(), causing a segfault. This may happen when, e.g., a panel-close occurs in <perspective-workspace> quickly after a draw() was triggered on that panel, before it completes.
  • Fixes threshold for light DOM update trigger, which caused errors when customizations are applied to a <perspective-viewer> in a workspace, which is subsequently closed.

@texodus texodus merged commit ea0385d into master Dec 14, 2021
@texodus texodus deleted the fix-workspace-crash branch December 14, 2021 04:24
@texodus texodus added the bug Concrete, reproducible bugs label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant