Overload re2 cmakelists to fix cmake/threads detection issue on conda-forge mac builds, and pin C++ dependency versions #1634
Conversation
timkpaine
added
dependencies
internal
|
Is this a fix for the CI failure in #1632? |
|
Tangentially related, i think re2's Cmakelists is incompatible with certain versions of mac os SDK (leading to the failures we see over on conda) so this applies the threading fix into it directly. #1632 would let you rely on a preinstalled version of re2 (and/or exprtk, and i'll have it do rapidjson and all our others) which will let us abide more by the rules of ecosystems like conda (and by extension, athena) by optionally not vendoring our dependencies at build time (but by still allowing that to keep our lives sane for our nice static builds for JS). |
timkpaine
changed the title
timkpaine
changed the title
|
had to blow away yarn cache, full build in: https://dev.azure.com/finosfoundation/perspective/_build/results?buildId=3647&view=results |
|
@texodus i think windows yarn cache is broken, did you run into this before? on another branch i turned it off, if thats acceptable i can do it here |
|
Yes I have encountered this before and Azure has less-than-helpful advice for resolving it (e.g. rename the cache ona new branch). I am skeptical that perspective w/esbuild even benefits from this in terms of build time, so if its a blocker I think it is safe to remove. |
No description provided.