Add auto-resizing to <perspective-viewer>
#1633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds auto-reiszing behavior (on by default) to
<perspective-viewer>
, via an internalResizeHandler
on these elements. As a result,notifyResize()
is no longer needed for resizing strictly and will likely eventually be removed as it can lead to duplicate re-renders. For now, it has been preserved and behavior modified slightly - callingnotifyResize()
when auto-sizing is enabled will log a warning and disable auto-size, unless theforce
bool argument is provided.Auto size behavior can be disabled, reverting to the old manual resize logic via
notifyResize()
(which will not warn in this case), by callingsetAutoSize(false)
: